[libvirt] [Patch] Libvirt & Autobuild

[Mohammed Morsi]

Daniel P. Berrange wrote:
> On Thu, Jul 10, 2008 at 10:10:25AM -0400, Mohammed Morsi wrote:
>   
>> Attached is a small fix to get libvirt working w/ autobuild. Autobuild 
>> attempts to create and test the RPM, which lists the PolicyKit as one of 
>> the files to be installed, and thus if it is not installed, autobuild 
>> reports an error and fails. The was to get this file installed is to 
>> specify --with-polkit to ./autogen which I added to the autobuild.sh 
>> build script. (also the syntax check errors broke autobuild, but these 
>> have been fixed according to the latest email on the list). Knock on 
>> wood, after this libvirt should work w/ autobuild and will be built 
>> nightly, and I can finish getting oVirt working with it.
>>     
>
> Hmm, this shouldn't impact the RPM spec at all. The 'autogen.shj' call
> in the autobuild.sh only applies to the non-RPM build. The RPM build
> is done via 'configure' in the spec file itself. I think there's 
> something else going wrong you're hitting instead.
>
>   
I'm not expert on autotools, but doesnt autogen.sh traditionally take 
the configure.ac and Makefile.am files and generate the configure script 
and make rules? While the build process isn't being held up at the 
configure or make stages, rather the rpmbuild stage, rpmbuild depends on 
the output of configure / make, which if --with-polkit is not enabled, 
will result in the PolityKit file not being included in the build and 
thus an error when rpm sees it listed under the files in the spec but 
not the actual file itself. Feel free to correct me if I'm wrong.

    -Mo

>> Index: autobuild.sh
>> ===================================================================
>> RCS file: /data/cvs/libvirt/autobuild.sh,v
>> retrieving revision 1.7
>> diff -u -r1.7 autobuild.sh
>> --- autobuild.sh	29 May 2008 20:43:08 -0000	1.7
>> +++ autobuild.sh	9 Jul 2008 18:09:11 -0000
>> @@ -16,7 +16,8 @@
>>  
>>  ./autogen.sh --prefix=$AUTOBUILD_INSTALL_ROOT \
>>    --enable-test-coverage \
>> -  --enable-compile-warnings=error
>> +  --enable-compile-warnings=error \
>> +  --with-polkit
>>  
>>  make
>>  make install
>>     
>
> Daniel
>   

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20080710/dbb7aae2/attachment-0001.htm>