[Libvir] Release of libvirt-0.4.1

[Guido Günther]

On Fri, Mar 07, 2008 at 04:23:13PM +0100, Guido Günther wrote:
> Hi Daniel.
> On Mon, Mar 03, 2008 at 10:13:12AM -0500, Daniel Veillard wrote:
> >   It was really time for a new release, quite a lot of patches had accumulated
> > since the previous one ! Available at 
> >     ftp://libvirt.org/libvirt
> Cool thing! Unfortunatley this release breaks kvm/qemu bridged
> networking for me. Namely this commmit:
> 
>  936dd984eed33813aa69b0377dd46a9ad1e9e014
>  Set MAC address on TUN device for Xenner compatability
> 
> With this applied the vm never sees the dhcp offer from the DHCP
> server.  When I revert the patch, everything is fine again.
No comments? This is the part of code I've reverted. Didn't find the
time to track down the problem for real:

diff --git a/src/bridge.c b/src/bridge.c
index 6626156..caa6ebf 100644
--- a/src/bridge.c
+++ b/src/bridge.c
@@ -357,18 +355,6 @@ brAddTap(brControl *ctl,
         }
 
         if (ioctl(fd, TUNSETIFF, &try) == 0) {
-            struct ifreq addr;
-            memset(&addr, 0, sizeof(addr));
-            memcpy(addr.ifr_hwaddr.sa_data, macaddr, 6);
-            addr.ifr_hwaddr.sa_family = ARPHRD_ETHER;
-
-            /* Device actually starts in 'UP' state, but it
-             * needs to be down to set the MAC addr
-             */
-            if ((errno = brSetInterfaceUp(ctl, try.ifr_name, 0)))
-                goto error;
-            if (ioctl(fd, SIOCSIFHWADDR, &addr) != 0)
-                goto error;
             if ((errno = brAddInterface(ctl, bridge, try.ifr_name)))
                 goto error;
             if ((errno = brSetInterfaceUp(ctl, try.ifr_name, 1)))

 -- Guido