[libvirt] PATCH: Fix QEMU/UML use of libnuma

Daniel Veillard veillard at redhat.com
Thu Nov 27 17:26:02 UTC 2008

On Thu, Nov 27, 2008 at 01:26:28PM +0000, Daniel P. Berrange wrote:
> The 2.x series of numactl releases changed the ABI/API for certain
> libnuma.so functions we use. Fortunately it turns out that they provide
> back-compatability of both ABI and API with a combo of linker script
> magic, and header file inline compat functions. So, all we need todo
> is #define NUMA_VERSION1_COMPATIBILITY before include numa.h in our
> code.
> This new code did, however, expose a bug in our use of the existing
> API. We were calculating size in bytes, instead of size in longs, so
> were passing a buffer that was 8 times to large. Harmless, but the
> new libnuma validates that the buffer is expected size. So this patch
> also fixes us to pass & allocate correct  buffer size. 
> Finally, also add a missing BuildRequire on numactl-devel, and fixes
> the libvirtd automake build dependancy

  Okay, the only question I have is if we should not avoid the
NUMA_VERSION1_COMPATIBILITY in the future and limit it to compatibility
with older systems.



Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel at veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

More information about the libvir-list mailing list