[libvirt] [PATCH] trivial fix for virsh return value bug

Daniel Veillard veillard at redhat.com
Wed Apr 15 19:49:23 UTC 2009


https://bugzilla.redhat.com/show_bug.cgi?id=495954

virsh ttyconsole [node] always sets a return code of 1
we initialize ret to FALSE, but don't set it to TRUE when the operation
succeeds

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel at veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/
-------------- next part --------------
Index: src/virsh.c
===================================================================
RCS file: /data/cvs/libxen/src/virsh.c,v
retrieving revision 1.200
diff -u -u -p -r1.200 virsh.c
--- src/virsh.c	3 Apr 2009 14:03:38 -0000	1.200
+++ src/virsh.c	15 Apr 2009 19:48:49 -0000
@@ -4930,6 +4930,7 @@ cmdTTYConsole(vshControl *ctl, const vsh
         goto cleanup;
     }
     vshPrint(ctl, "%s\n", (const char *)obj->stringval);
+    ret = TRUE;
 
  cleanup:
     xmlXPathFreeObject(obj);


More information about the libvir-list mailing list