[libvirt] [PATCH]: Fix qemu+tls negotiation

Chris Lalancette clalance at redhat.com
Tue Mar 3 08:05:52 UTC 2009

     While doing testing on the migration stuff, I noticed that a connection
string using tls (in my case, qemu+tls://host/system) was hanging up trying to
connect.  I traced this down to a bug in the newer qemud negotiation
implementation.  What is happening is that we are forgetting to clear
client->handshake to 0 after successfully doing a remoteAccessCheck(); this
means we were never putting the '\1' byte on the transmit queue to be sent to
the client, so the client was essentially waiting forever for the server to
respond.  Fix this by clearing the handshake once we've successfully done the

Signed-off-by: Chris Lalancette <clalance at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt-fix-tls.patch
Type: text/x-patch
Size: 912 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20090303/3b132dff/attachment-0001.bin>

More information about the libvir-list mailing list