[libvirt] [PATCH]: Fix qemu+tls negotiation

Daniel Veillard veillard at redhat.com
Tue Mar 3 08:27:13 UTC 2009

On Tue, Mar 03, 2009 at 09:05:52AM +0100, Chris Lalancette wrote:
> All,
>      While doing testing on the migration stuff, I noticed that a connection
> string using tls (in my case, qemu+tls://host/system) was hanging up trying to
> connect.  I traced this down to a bug in the newer qemud negotiation
> implementation.  What is happening is that we are forgetting to clear
> client->handshake to 0 after successfully doing a remoteAccessCheck(); this
> means we were never putting the '\1' byte on the transmit queue to be sent to
> the client, so the client was essentially waiting forever for the server to
> respond.  Fix this by clearing the handshake once we've successfully done the
> handshake.

  Okay, that looks logical, nowhere in the code the handshake bit
was set back to 0. I applied it myself since I expect a release in the
next hours,

  thanks !


Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel at veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

More information about the libvir-list mailing list