[libvirt] [PATCH] esx: Fix FindByIp response handling

Matthias Bolte matthias.bolte at googlemail.com
Sun Apr 18 20:32:46 UTC 2010


FindByIp may return nothing if there is no host or virtual machine
with the given IP address. Handle that case properly.
---
 src/esx/esx_vi.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c
index 37270fe..c6854f1 100644
--- a/src/esx/esx_vi.c
+++ b/src/esx/esx_vi.c
@@ -1968,6 +1968,13 @@ esxVI_LookupHostSystemByIp(esxVI_Context *ctx, const char *ipAddress,
         goto failure;
     }
 
+    if (managedObjectReference == NULL) {
+        ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR,
+                     _("Could not find host system with IP address '%s'"),
+                     ipAddress);
+        goto failure;
+    }
+
     if (esxVI_LookupObjectContentByType(ctx, managedObjectReference,
                                         "HostSystem", propertyNameList,
                                         esxVI_Boolean_False, hostSystem) < 0) {
-- 
1.6.3.3




More information about the libvir-list mailing list