[libvirt] [PATCH] esx: Fix FindByIp response handling

Eric Blake eblake at redhat.com
Tue Apr 20 20:06:20 UTC 2010


On 04/18/2010 02:32 PM, Matthias Bolte wrote:
> FindByIp may return nothing if there is no host or virtual machine
> with the given IP address. Handle that case properly.
> ---
>  src/esx/esx_vi.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c
> index 37270fe..c6854f1 100644
> --- a/src/esx/esx_vi.c
> +++ b/src/esx/esx_vi.c
> @@ -1968,6 +1968,13 @@ esxVI_LookupHostSystemByIp(esxVI_Context *ctx, const char *ipAddress,
>          goto failure;
>      }
>  
> +    if (managedObjectReference == NULL) {
> +        ESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR,
> +                     _("Could not find host system with IP address '%s'"),
> +                     ipAddress);
> +        goto failure;
> +    }

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100420/51225739/attachment-0001.sig>


More information about the libvir-list mailing list