[libvirt] [PATCH V2] nwfilter: lock interface by its index

Stefan Berger stefanb at us.ibm.com
Thu Apr 22 19:53:13 UTC 2010


Daniel Veillard <veillard at redhat.com> wrote on 04/22/2010 07:41:47 AM:


> 
> [...]
> > 
> > +    if (virNWFilterLockIface(req->ifname))
> > +       goto err_no_lock;
> > +
> 
>  As long as the error is caught when used,  and properly propagated
> that strategy is correct IMHO.
> 
>   otherwise, patch looks okay to me,
> 
> ACK once those forever loops are replaced with error returns.

I fixed this and pushed it. I had to also remove an ifaceDown() call and 
precede another one with ifaceCheck().

   Stefan

> 
> Daniel
> 
> -- 
> Daniel Veillard      | libxml Gnome XML XSLT toolkit  
http://xmlsoft.org/
> daniel at veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
> http://veillard.com/ | virtualization library  http://libvirt.org/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100422/8a4adab2/attachment-0001.htm>


More information about the libvir-list mailing list