[libvirt] cygwin: #include netinet/inet.h -- needed only on cygwin

[Stefan Berger]

libvir-list-bounces at redhat.com wrote on 08/17/2010 02:12:44 PM:


> libvir-list
> 
> On 08/17/2010 10:48 AM, Stefan Berger wrote:
> >  On 08/17/2010 12:25 PM, Daniel P. Berrange wrote:
> >> On Tue, Aug 17, 2010 at 12:14:47PM -0400, Stefan Berger wrote:
> >>>   When doing './autogen.sh --with-sasl --with-libvirtd=no' on 
cygwin, I
> >>> needed to #include netinet/in.h for a successful build. Now
> >>> authentication using SASL works.
> >> Hmm, this is the sort of thing that GNULIB usually fixes for
> >> us. What is the compile error without this patch present ?
> >> Ideally we can get GNULIB to fix it
> 
> Well, gnulib does not yet offer any replacements for the <rpc/....h>
> headers, in part because they are not standardized by POSIX.  That's
> certainly a larger task than just working around it for now in libvirt.
> 
> The real question here is whether cygwin's <rpc/rpc.h> is broken because
> it is not self-sufficient, or whether the compile error is due to
> something else that libvirt is doing.  Which is why the actual compile
> message is important (so I went and reproduced this setup - it took me
> more than an hour to get to the failure point)...
> 
> > It complains about an incomplete datatype due to sockaddr_in being 
used
> > in rpc/svc.h (xp_raddr in SVCXPRT struct).
> 
> I could not reproduce the failure with the latest cygwin:
> cygwin               1.7.6-1        OK
> libsasl2-devel       2.1.23-1       OK
> libxml2-devel        2.7.7-1        OK
> sunrpc               4.0-3          OK
> 
> What versions do you have installed?  (Not sure if I have any other
> relevant installed packages that I didn't list here).

I had done updates just yesterday... Now I did a reinstall on the sunrpc 
4.0-3 I already had and the rpc/types.h changed and it does now have the 
include of netinet/in.h as well. This of course makes the patch 
unnecessary.

  Stefan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100817/c0d5910d/attachment-0001.htm>