[libvirt] [PATCH v3 10/14] Add qemu support

Stefan Berger stefanb at us.ibm.com
Thu Mar 25 14:33:18 UTC 2010

"Daniel P. Berrange" <berrange at redhat.com> wrote on 03/25/2010 10:18:25 

> Please respond to "Daniel P. Berrange"
> On Thu, Mar 25, 2010 at 10:02:38AM -0400, Stefan Berger wrote:

> > Due to these and other changes I would like to post a 'v4' patch 
> > with an additional patch installing a couple of example filters.
> That's fine with me - BTW, i notice in the nwfilter_conf.c some of the
> objects are called 'FilterPool' instead of just 'Filter' - is that 
> delibrate, or a cut +paste mistake from copying existing storage_conf.c
> code.

Some of that is (still) deliberate because from the perspective of the 
driver I
regard the collection of filters as a pool and within that pool I can 
for filters by for example UUID or name and that's where function names 
virNWFilterPoolObjFindByUUID/ByName stem from. So, yes, it's derived from
storage_conf.c but to me the naming of those functions still makes 


> Daniel
> -- 
> |: Red Hat, Engineering, London    -o-   
> |: http://libvirt.org -o- http://virt-manager.org -o- 
> |: http://autobuild.org        -o-         
> |: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 
9505 :|
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100325/c9a20872/attachment-0001.htm>

More information about the libvir-list mailing list