[libvirt] locking down struct size/layout in remote-protocol.x

Eric Blake eblake at redhat.com
Mon May 10 20:38:42 UTC 2010


On 05/10/2010 02:36 PM, Jim Meyering wrote:
> Eric Blake wrote:
>> On 05/07/2010 03:23 PM, Jim Meyering wrote:
>>> +remote_protocol-structs:
>>> +	$(AM_V_GEN)if pdwtags --help > /dev/null 2>&1; then		\
>>
>> Some shells (at least Solaris /bin/sh) are noisy in spite of the
>> redirections, when a program doesn't exist.  I'm proposing a followup
>> patch to clean up this invocation to use a subshell, and also to fix the
>> subshell for cppi in cfg.mk.
> 
> Or you could consider the noise a two-pronged feature:
>   - notify user that their $(SHELL) is inferior
>   - more noise about lack of a useful developer tool (pdwtags or cppi)

In which case, your pdwtags usage is fine, and I should modify my patch
to just drop the cppi subshell altogether?

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100510/ed1776b5/attachment-0001.sig>


More information about the libvir-list mailing list