[libvirt] [PATCH] vmx: Add support for video device VRAM size
Matthias Bolte
matthias.bolte at googlemail.com
Thu Jan 6 17:19:42 UTC 2011
2011/1/4 Eric Blake <eblake at redhat.com>:
> On 12/30/2010 10:14 AM, Matthias Bolte wrote:
>> Update test suite accordingly.
>
>> +
>> + virBufferVSprintf(buffer, "svga.vramSize = \"%d\"\n",
>> + def->vram * 1024); /* Scale from kilobytes to bytes */
>
> Should this be %lld, def->vram * 1024ll, to avoid overflow concerns?
Sure, doesn't hurt to do so.
> Otherwise, it looks okay to me. Conditional ACK based on the answer to
> that question.
Thanks, I folded in the LL suggestion and pushed the result.
Matthias
More information about the libvir-list
mailing list