[libvirt] [PATCH 0/3] Detect netcat implementation

Guido Günther agx at sigxcpu.org
Wed Oct 12 22:38:40 UTC 2011


Hi,
Finally here's a respin of the netcat detection when used over SSH.
Changes are:

* virBufferQuoteString renamed to virBufferEscapeShell
* Use outer quote only when metacharacters show up
* Make a pessimistic buffer allocation instead of resizing it all the
  time

Cheers,
 -- Guido

Guido Günther (3):
  Autodetect if the remote nc command supports the -q option
  Add virBufferEscapeShell
  Use virBufferEscapeShell in virNetSocketNewConnectSSH

 src/libvirt_private.syms |    1 +
 src/rpc/virnetsocket.c   |   38 +++++++++++++++++++++++++++++--
 src/util/buf.c           |   54 ++++++++++++++++++++++++++++++++++++++++++++++
 src/util/buf.h           |    1 +
 tests/virnetsockettest.c |   11 +++++----
 5 files changed, 97 insertions(+), 8 deletions(-)

-- 
1.7.6.3




More information about the libvir-list mailing list