[libvirt] Compiler warnings

[Alex Jia]

Eric,
It's latest libvirt upstream, current commit id is commit 0a71c79.

# rpm -q glibc
glibc-2.12-1.42.el6.x86_64

399 void
400 virBufferEscape(const virBufferPtr buf,
401                 const char *toescape,
402                 const char *format,
403                 const char *str)
404 {
.....

427     cur = str;
428     out = escaped;
429     while (*cur != 0) {
430         if (strchr(toescape, *cur))
431             *out++ = '\\';
432         *out++ = *cur;
433         cur++;
434     }

......


Regards,
Alex



----- Original Message -----
From: "Eric Blake" <eblake at redhat.com>
To: "Alex Jia" <ajia at redhat.com>
Cc: libvir-list at redhat.com
Sent: Tuesday, October 18, 2011 12:11:19 AM
Subject: Re: [libvirt]  Compiler warnings

On 10/17/2011 09:51 AM, Alex Jia wrote:
> Eric,
> # rpm -q gcc
> gcc-4.4.6-3.el6.x86_64

I'm still not seeing it on my RHEL 6 host.  What version of glibc (in 
case it's a header problem), and is this the latest libvirt.git or a 
particular source rpm rebuild?  What's on line 430 of the file in question?

>>     CC     libvirt_util_la-buf.lo
>> util/buf.c: In function 'virBufferEscape':
>> util/buf.c:430: warning: logical '&&' with non-zero constant will always
>> evaluate as true [-Wlogical-op]

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org