[libvirt] [PATCH 1/2] qemu: Fix name-space handling

Eric Blake eblake at redhat.com
Wed Oct 19 13:59:28 UTC 2011


On 10/19/2011 01:44 AM, Daniel P. Berrange wrote:
> On Tue, Oct 18, 2011 at 06:22:49PM +0200, Philipp Hahn wrote:
>> The XML parser for the qemu specific extensions expects the qemu name-space
>> to be bound to the 'qemu' prefix. This is too strict, since the name of the
>> name-space-prefix is only mend as an internal lookup key. Only the associated

s/mend/meant/

>> URI is relevant.
>> <domain>...
>>    <qemu:commandline xmlns:qemu="http://libvirt.org/schemas/domain/qemu/1.0">
>>    ...</qemu:commandline>
>> </domain>
>>
>> <domain xmlns:ns0="http://libvirt.org/schemas/domain/qemu/1.0">...
>>    <ns0:commandline>
>>    ...</ns0:commandline>
>> </domain>
>>
>> <domain xmlns:qemu="http://libvirt.org/schemas/domain/qemu/1.0">
>>    <qemu:commandline xmlns:qemu="urn:foo">
>>    ...</qemu:commandline>
>> </domain>
>>
>> Remove the test for checking the name-space binding on the top-level<domain>
>> element. Registering the name-space with XPath is enough.
>>
>> Signed-off-by: Philipp Hahn<hahn at univention.de>
>> ---
>>   src/qemu/qemu_domain.c |   30 ++++++++++++------------------
>>   1 files changed, 12 insertions(+), 18 deletions(-)
>
> ACK

Pushed.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list