[libvirt] [PATCHv2 09/13] snapshot: simplify indentation of network xml

Peter Krempa pkrempa at redhat.com
Thu Oct 20 13:00:04 UTC 2011


On 09/29/2011 06:22 PM, Eric Blake wrote:
> More simplifications possible due to auto-indent.  Also,
> <bandwidth>  within<actual>  was only using 6 instead of 8 spaces.
>
> * src/util/network.h (virVirtualPortProfileFormat)
> (virBandwidthDefFormat): Alter signature.
> * src/util/network.c (virVirtualPortProfileFormat)
> (virBandwidthDefFormat): Alter indentation.
> (virBandwidthChildDefFormat): Tweak to make use easier.
> * src/conf/network_conf.c (virPortGroupDefFormat)
> (virNetworkDefFormat): Adjust callers.
> * src/conf/domain_conf.c (virDomainNetDefFormat): Likewise.
> (virDomainActualNetDefFormat): Likewise, and fix bandwidth
> indentation.
> ---
>   src/conf/domain_conf.c  |   23 ++++++++++++++-------
>   src/conf/network_conf.c |   14 +++++++++---
>   src/util/network.c      |   49 ++++++++++++++++------------------------------
>   src/util/network.h      |   11 ++++-----
>   4 files changed, 47 insertions(+), 50 deletions(-)
>

> diff --git a/src/util/network.h b/src/util/network.h
> index 4d195af..552d5fd 100644
> --- a/src/util/network.h
> +++ b/src/util/network.h
> @@ -1,7 +1,7 @@
>   /*
>    * network.h: network helper APIs for libvirt
>    *
> - * Copyright (C) 2009-2009 Red Hat, Inc.
> + * Copyright (C) 2009-2009, 2011 Red Hat, Inc.

2009-2009? Wouldn't it be better to state "2009, 20011"?

>    *


ACK,

Peter




More information about the libvir-list mailing list