[libvirt] [PATCH] lxc: avoid missing '{' in the function

[Alex Jia]

On 10/27/2011 05:26 PM, Daniel P. Berrange wrote:
> On Thu, Oct 27, 2011 at 04:51:05PM +0800, Alex Jia wrote:
>> On 10/27/2011 04:15 PM, Daniel P. Berrange wrote:
>>> On Thu, Oct 27, 2011 at 03:17:59PM +0800, ajia at redhat.com wrote:
>>>> From: Alex Jia<ajia at redhat.com>
>>>>
>>>> Cppcheck detected a syntaxError on lxcDomainInterfaceStats.
>>>>
>>>> * src/lxc/lxc_driver.c: fixed missing '{' in the function lxcDomainInterfaceStats.
>>>>
>>>> Signed-off-by: Alex Jia<ajia at redhat.com>
>>>> ---
>>>>   src/lxc/lxc_driver.c |    1 +
>>>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
>>>> index f08e8d1..06bfa85 100644
>>>> --- a/src/lxc/lxc_driver.c
>>>> +++ b/src/lxc/lxc_driver.c
>>>> @@ -2671,6 +2671,7 @@ static int
>>>>   lxcDomainInterfaceStats(virDomainPtr dom,
>>>>                           const char *path ATTRIBUTE_UNUSED,
>>>>                           struct _virDomainInterfaceStats *stats ATTRIBUTE_UNUSED)
>>>> +{
>>>>       lxcError(VIR_ERR_NO_SUPPORT, "%s", __FUNCTION__);
>>>>       return -1;
>>>>   }
>>> Hmm, I dunno why we even have a '#ifdef __linux__' in that file
>>> since the entire file is Linux specific. We should just kill this
>>> #else clause entirely
>> You mean we should remove the following lines rather then reserving
>> the function as
>> a optional branch:
>> #else
>> static int
>> lxcDomainInterfaceStats(virDomainPtr dom,
>>                          const char *path ATTRIBUTE_UNUSED,
>>                          struct _virDomainInterfaceStats *stats
>> ATTRIBUTE_UNUSED)
>>      lxcError(VIR_ERR_NO_SUPPORT, "%s", __FUNCTION__);
>>      return -1;
>> }
>>
>> If so, need I commit a v2 patch for this?
> Yes, just remove that dummy function entirely.
>
> Regards,
> Daniel
Okay, I will commit a new patch for this instead of v2,
because the patch summary isn't appropriate.

Thanks,
Alex