[libvirt] [PATCH] qemu: avoid leaking uninit data from hotplug to dumpxml

Eric Blake eblake at redhat.com
Fri Oct 28 15:24:09 UTC 2011


On 10/28/2011 08:59 AM, Laine Stump wrote:
> On 10/26/2011 07:42 PM, Eric Blake wrote:
>> Detected by Coverity. The fix in 2c27dfa didn't catch all bad
>> instances of memcpy(). Thankfully, on further analysis, all of
>> the problematic uses are only triggered by old qemu that lacks
>> -device.
>>
>> * src/qemu/qemu_hotplug.c (qemuDomainAttachPciDiskDevice)
>> (qemuDomainAttachNetDevice, qemuDomainAttachHostPciDevice): Init
>> all fields since monitor only populates some of them.
>
> ACK.

Thanks; pushed.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list