[libvirt] [PATCH] qemu: plug memory leak

ajia at redhat.com ajia at redhat.com
Sat Oct 29 17:12:56 UTC 2011


From: Alex Jia <ajia at redhat.com>

Detected by Coverity. Leak introduced in commit 6cabc0b.

* src/qemu/qemu_command.c: Clean up on failure. 

Signed-off-by: Alex Jia <ajia at redhat.com>
---
 src/qemu/qemu_command.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 0936492..02958cb 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -4995,6 +4995,7 @@ qemuBuildCommandLine(virConnectPtr conn,
                 }
 
                 if (sound->model == VIR_DOMAIN_SOUND_MODEL_ICH6) {
+                    VIR_FREE(modstr);
                     qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                                     _("this QEMU binary lacks hda support"));
                     goto error;
-- 
1.7.1




More information about the libvir-list mailing list