[libvirt] [PATCH v2] Pull DBus event code out into common area
Daniel P. Berrange
berrange at redhat.com
Fri Apr 13 09:27:49 UTC 2012
On Thu, Apr 12, 2012 at 05:34:54PM -0600, Eric Blake wrote:
> On 04/12/2012 02:07 PM, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange at redhat.com>
> >
> > The policy kit and HAL node device drivers both require a
> > DBus connection. The HAL device code further requires that
> > the DBus connection is integrated with the event loop and
> > provides such glue logic itself.
> >
> > The forthcoming FirewallD integration also requires a
> > dbus connection with event loop integration. Thus we need
> > to pull the current event loop glue out of the HAL driver.
> >
> > Thus we create src/util/virdbus.{c,h} files. This contains
> > just one method virDBusGetSystemBus() which obtains a handle
> > to the single shared system bus instance, with event glue
> > automagically setup.
> > ---
> > .gitignore | 6 +-
> > configure.ac | 37 ++++++-
> > daemon/Makefile.am | 3 +-
> > daemon/libvirtd.c | 4 -
> > daemon/remote.c | 8 +-
> > include/libvirt/virterror.h | 1 +
> > src/Makefile.am | 13 +--
> > src/libvirt_dbus.syms | 2 -
>
> You're dropping libvirt_dbus.syms, but I don't see where you are
> modifying libvirt_private.syms to make up for it.
The symbol in question was completely deleted from the code.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list