[libvirt] [PATCH] S390: Fix virSysinfoRead memory corruption

Viktor Mihajlovski mihajlov at linux.vnet.ibm.com
Mon Dec 10 08:47:04 UTC 2012


On 12/07/2012 06:57 PM, Eric Blake wrote:

>
> No.  Don't use index(), as it is not guaranteed to exist.
>
> What we should _really_ do is provide a change in
> m4/virt-compile-warnings.m4 that disables -Wlogical-op if compiling with
> a broken gcc, now that newer gcc doesn't force its stupidity on a
> sensible strchr() usage.  I'll attempt that patch independently, and
> then your patch can go on top using strchr() from the get-go.
>

Good! I will need to add a testcase per Daniel's comment anyway, so
there's time...

-- 

Mit freundlichen Grüßen/Kind Regards
    Viktor Mihajlovski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294




More information about the libvir-list mailing list