[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/4] qemu: add boot order support for redirected and host USB devices

On 11/21/2012 10:43 AM, Michal Privoznik wrote:
> On 20.11.2012 19:47, Ján Tomko wrote:
>> Commit a4c19459aa8634c43b51e8138fb1d7eec4c17824 missed the functionality
>> for redirected USB devices (fixed in 1/4), documentation and tests.
>> https://bugzilla.redhat.com/show_bug.cgi?id=805414
> I went ahead, ACKed and pushed this. However, meanwhile I've:
> -split 2/4 patch into two smaller ones
> -split huge line in 3/4
> -fixed space at EOL in 4/4

I think you should undo this fix, and match actual qemu output (even if
it DOES have a trailing space), as that particular file should be exempt
from whitespace enforcement.  (If git gives you problems for pushing a
trailing space, ping me on IRC, and I'll help you figure out what to tweak).

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]