[libvirt] [PATCH] qemu: Drop qemuDomainMemoryLimit
Ján Tomko
jtomko at redhat.com
Mon Aug 19 15:02:48 UTC 2013
On 08/09/2013 02:56 PM, Michal Privoznik wrote:
> This function is to guess the correct limit for maximal memory
> usage by qemu for given domain. This can never be guessed
> correctly, not to mention all the pains and sleepless nights this
> code has caused. Once somebody discovers algorithm to solve the
> Halting Problem, we can compute the limit algorithmically. But
> till then, this code should never see the light of the release
> again.
> ---
> src/qemu/qemu_cgroup.c | 3 +--
> src/qemu/qemu_command.c | 2 +-
> src/qemu/qemu_domain.c | 49 -------------------------------------------------
> src/qemu/qemu_domain.h | 2 --
> src/qemu/qemu_hotplug.c | 2 +-
> 5 files changed, 3 insertions(+), 55 deletions(-)
>
I can't start any domains that don't have the hard limit set with this patch.
It seems we should only set the limit if its non-zero.
Jan
More information about the libvir-list
mailing list