[libvirt] [PATCH] qemuAgentDispose: Reset lastError

Wangyufei (James) james.wangyufei at huawei.com
Thu Dec 5 02:01:43 UTC 2013


In fact the patch is attributed to Zhou Yimin. Well, it's my fault, next time I'll add information like this:

>From b35621412f94df8e2db165aa85d153a5facc6fa1 Mon Sep 17 00:00:00 2001
From: Zhou Yimin <zhouyimin at huawei.com>
Date: Tue, 3 Dec 2013 09:54:01 +0800
Subject: [PATCH] qemuAgentDispose: Reset lastError

When an error occurred in qemuAgentIO, it will be saved in mon->lastError,
but it will not be freed at last.
So I add the following code to fix it.



> -----Original Message-----
> From: Eric Blake [mailto:eblake at redhat.com]
> Sent: Thursday, December 05, 2013 5:51 AM
> To: Wangyufei (James); libvir-list at redhat.com
> Cc: zhouyimin Zhou(Yimin); Wangrui (K)
> Subject: Re: [libvirt] [PATCH] qemuAgentDispose: Reset lastError
> 
> On 12/04/2013 02:44 PM, Eric Blake wrote:
> > On 12/02/2013 07:59 PM, Wangyufei (James) wrote:
> >> When an error occurred in qemuAgentIO, it will be saved in
> mon->lastError,
> >> but it will not be freed at last.
> 
> >>
> >> Signed-off-by: Zhou Yimin <zhouyimin at huawei.com>
> 
> I've already pushed, but note that the commit is now attributed to
> Wangyufei even though the S-o-B is from Zhou Yimin.  I hope this didn't
> create a situation of a misattributed patch.  Remember that 'git
> send-email' can be configured to add a 'From: ...' line at the top of
> messages to ensure that on the receiving end, doing 'git am' will pick
> the correct author name even if it differs from the person sending the
> patch.
> 
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org





More information about the libvir-list mailing list