[libvirt] [PATCH 1/1] Remove contiguous CPU indexes assumption

[Li Zhang]

Hi Eric,

This should belong to bug-fix, could it be pushed to 1.0.3?

Thanks.


On Wed, Feb 27, 2013 at 11:18 AM, Li Zhang <zhlcindy at gmail.com> wrote:

> From: Li Zhang <zhlcindy at linux.vnet.ibm.com>
>
> When getting CPUs' information, it assumes that CPU indexes
> are not contiguous. But for ppc64 platform, CPU indexes are not
> contiguous because SMT is needed to be disabled, so CPU information
> is not right on ppc64 and vpuinfo, vcpupin can't work corretly.
>
> This patch is to remove the assumption to be compatible with ppc64.
>
> Test:
>    4 vcpus are assigned to one VM and execute vcpuinfo command.
>
>    Without patch: There is only one vcpu informaion can be listed.
>    With patch: All vcpus' information can be listed correctly.
>
> Signed-off-by: Li Zhang <zhlcindy at linux.vnet.ibm.com>
> ---
>  src/qemu/qemu_monitor_json.c |    7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
> index 9991a0a..e130f8c 100644
> --- a/src/qemu/qemu_monitor_json.c
> +++ b/src/qemu/qemu_monitor_json.c
> @@ -1230,13 +1230,6 @@ qemuMonitorJSONExtractCPUInfo(virJSONValuePtr reply,
>              goto cleanup;
>          }
>
> -        if (cpu != i) {
> -            virReportError(VIR_ERR_INTERNAL_ERROR,
> -                           _("unexpected cpu index %d expecting %d"),
> -                           i, cpu);
> -            goto cleanup;
> -        }
> -
>          threads[i] = thread;
>      }
>
> --
> 1.7.10.1
>
>


-- 

Best Regards
-Li
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130227/14570a47/attachment-0001.htm>