[libvirt] [PATCHv2 10/10] nodeinfo: Remove libnuma include

[Eric Blake]

On 11/04/2013 05:36 AM, Ján Tomko wrote:
> On 10/18/2013 05:05 PM, Peter Krempa wrote:
>> Now that all libnuma functions used by libvirt are wrapped in virNuma we
>> can remove the dependancy from nodeinfo.
>> ---
>>  src/nodeinfo.c | 26 --------------------------
>>  1 file changed, 26 deletions(-)


> 
> This broke the build on FreeBSD:
> 
>   CC       libvirt_driver_la-nodeinfo.lo
> nodeinfo.c: In function 'virNodeGetSiblingsList':

I also assume (but haven't actually bisected) that this series is
responsible for a break in mingw:

  CC       libvirt_driver_la-nodeinfo.lo
../../src/nodeinfo.c: In function 'virNodeGetSiblingsList':
../../src/nodeinfo.c:1543:30: error:
'SYSFS_THREAD_SIBLINGS_LIST_LENGTH_MAX' undeclared (first use in this
function)
     if (virFileReadAll(path, SYSFS_THREAD_SIBLINGS_LIST_LENGTH_MAX,
&buf) < 0)
                              ^
../../src/nodeinfo.c:1543:30: note: each undeclared identifier is
reported only once for each function it appears in
../../src/nodeinfo.c: In function 'virNodeCapsFillCPUInfo':
../../src/nodeinfo.c:1562:5: error: implicit declaration of function
'virNodeGetCpuValue' [-Werror=implicit-function-declaration]
     if ((tmp = virNodeGetCpuValue(SYSFS_CPU_PATH, cpu_id,
     ^
../../src/nodeinfo.c:1562:5: error: nested extern declaration of
'virNodeGetCpuValue' [-Werror=nested-externs]
../../src/nodeinfo.c:1562:35: error: 'SYSFS_CPU_PATH' undeclared (first
use in this function)
     if ((tmp = virNodeGetCpuValue(SYSFS_CPU_PATH, cpu_id,
                                   ^
cc1: all warnings being treated as errors



-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131105/2dd2c422/attachment-0001.sig>