[libvirt] [PATCH] Add hw random number generator (/dev/hwrng) to default qemu cgroup ACL

[Pradipta Kumar Banerjee]

On 11/18/2013 09:35 PM, Eric Blake wrote:
> On 11/18/2013 08:20 AM, Daniel P. Berrange wrote:
> 
>>>  static const char *const defaultDeviceACL[] = {
>>>      "/dev/null", "/dev/full", "/dev/zero",
>>> -    "/dev/random", "/dev/urandom",
>>> +    "/dev/random", "/dev/urandom", "/dev/hwrng",
>>>      "/dev/ptmx", "/dev/kvm", "/dev/kqemu",
>>>      "/dev/rtc", "/dev/hpet", "/dev/vfio/vfio",
>>>      NULL,
>>
>> NACK, for any device listed in the XML, we should add it in the per-VM
>> cgroups setup code.
>>
>> The existing /dev/random & /dev/urandom devices are there because they
>> are used for basic crypto libraries unrelated to the XML config.
> 
> /dev/urandom, probably.  /dev/random - really?  Isn't that a DoS
> potential for one guest to starve entropy from other guests, in spite of
> sVirt?
I think you are right ..

> 
>> The
>> /dev/hwrng device does not fall into this scenario.
> 
> Agreed.
> 


-- 
Regards,
Pradipta