[libvirt] [libvirt-sandbox] GVirSandboxConfigNetwork: Fix small finalize() leak

Daniel P. Berrange berrange at redhat.com
Thu Nov 21 14:22:49 UTC 2013


On Thu, Nov 21, 2013 at 03:07:49PM +0100, Christophe Fergeau wrote:
> The content of the 'addrs' and 'routes' lists is freed, but the list
> themselves were not g_list_free()'ed
> ---
>  libvirt-sandbox/libvirt-sandbox-config-network.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libvirt-sandbox/libvirt-sandbox-config-network.c b/libvirt-sandbox/libvirt-sandbox-config-network.c
> index 555a360..eb6a569 100644
> --- a/libvirt-sandbox/libvirt-sandbox-config-network.c
> +++ b/libvirt-sandbox/libvirt-sandbox-config-network.c
> @@ -131,7 +131,9 @@ static void gvir_sandbox_config_network_finalize(GObject *object)
>      g_free(priv->source);
>      g_free(priv->mac);
>      g_list_foreach(priv->addrs, (GFunc)g_object_unref, NULL);
> +    g_list_free(priv->addrs);
>      g_list_foreach(priv->routes, (GFunc)g_object_unref, NULL);
> +    g_list_free(priv->routes);
>  
>      G_OBJECT_CLASS(gvir_sandbox_config_network_parent_class)->finalize(object);
>  }

ACK


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list