[libvirt] [PATCH] qemuMigrationIsAllowed: Forbid migration of rebooting domain
Michal Privoznik
mprivozn at redhat.com
Thu Nov 21 14:26:33 UTC 2013
https://bugzilla.redhat.com/show_bug.cgi?id=744967
If a domain is rebooting and a migrate API is called meanwhile we would
have to transfer the fakeReboot attribute to the destination in order to
prevent domain doing plain shutdown over there. What about forbidding
this silly corner case instead? Same goes for saving a domain to a file.
Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
src/qemu/qemu_migration.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index e87ea85..6dffbb1 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -1399,6 +1399,14 @@ qemuMigrationIsAllowed(virQEMUDriverPtr driver, virDomainObjPtr vm,
size_t i;
if (vm) {
+ qemuDomainObjPrivatePtr priv = vm->privateData;
+
+ if (priv->fakeReboot) {
+ virReportError(VIR_ERR_OPERATION_INVALID, "%s",
+ _("domain is rebooting"));
+ return false;
+ }
+
if (qemuProcessAutoDestroyActive(driver, vm)) {
virReportError(VIR_ERR_OPERATION_INVALID,
"%s", _("domain is marked for auto destroy"));
--
1.8.4.4
More information about the libvir-list
mailing list