[libvirt] [PATCH] spec: Don't save/restore running VMs on libvirt-client update

[Eric Blake]

On 11/21/2013 01:15 PM, Cole Robinson wrote:
> Restarting an active libvirt-guests.service is the equivalent of
> doing:
> 
> /usr/libexec/libvirt-guests.sh stop
> /usr/libexec/libvirt-guests.sh start
> 
> Which in a default configuration will managedsave every running VM,
> and then restore them. Certainly not something we should do every
> time the libvirt-client RPM is updated.
> 
> Just drop the try-restart attempt, I don't know what purpose it
> serves anyways.

Probably put in as copy-and-paste from libvirtd by someone who didn't
understand services very well at the time the script was created.  For
libvirtd, it DOES make sense to restart (you want to be running the
latest bits for bug fixes, and restarting libvirtd has no impact to
running guests).

> 
> https://bugzilla.redhat.com/show_bug.cgi?id=962225
> ---
>  libvirt.spec.in | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

ACK.  (and goes to crawl in a hole for not investigating this further
back in May when I claimed it as a regression in behavior)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131121/93d4e027/attachment-0001.sig>