[libvirt] [PATCH] spec: Don't save/restore running VMs on libvirt-client update
Cole Robinson
crobinso at redhat.com
Fri Nov 22 15:23:02 UTC 2013
On 11/21/2013 04:54 PM, Eric Blake wrote:
> On 11/21/2013 01:15 PM, Cole Robinson wrote:
>> Restarting an active libvirt-guests.service is the equivalent of
>> doing:
>>
>> /usr/libexec/libvirt-guests.sh stop
>> /usr/libexec/libvirt-guests.sh start
>>
>> Which in a default configuration will managedsave every running VM,
>> and then restore them. Certainly not something we should do every
>> time the libvirt-client RPM is updated.
>>
>> Just drop the try-restart attempt, I don't know what purpose it
>> serves anyways.
>
> Probably put in as copy-and-paste from libvirtd by someone who didn't
> understand services very well at the time the script was created. For
> libvirtd, it DOES make sense to restart (you want to be running the
> latest bits for bug fixes, and restarting libvirtd has no impact to
> running guests).
>
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=962225
>> ---
>> libvirt.spec.in | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> ACK. (and goes to crawl in a hole for not investigating this further
> back in May when I claimed it as a regression in behavior)
>
Thanks, Pushed now
- Cole
More information about the libvir-list
mailing list