[libvirt] [PATCHv2] storage: expose volume meta-type in XML
Daniel P. Berrange
berrange at redhat.com
Mon Nov 25 17:06:31 UTC 2013
On Mon, Nov 25, 2013 at 09:56:48AM -0700, Eric Blake wrote:
> I got annoyed at having to use both 'virsh vol-list $pool --details'
> AND 'virsh vol-dumpxml $vol $pool' to learn if I had populated
> the volume correctly. Since two-thirds of the data present in
> virStorageVolGetInfo() already appears in virStorageVolGetXMLDesc(),
> this just adds the remaining piece of information, as:
>
> <volume type='...'>
> ...
> </volume>
>
> * docs/formatstorage.html.in: Document new <volume type=...>.
> * docs/schemas/storagevol.rng (vol): Add it to RelaxNG.
> * src/conf/storage_conf.h (virStorageVolTypeToString): Declare.
> * src/conf/storage_conf.c (virStorageVolTargetDefFormat): Output
> the metatype.
> (virStorageVolDefParseXML): Parse it, for unit tests.
> * tests/storagevolxml2xmlout/vol-*.xml: Update tests to match.
>
> Signed-off-by: Eric Blake <eblake at redhat.com>
ACK
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list