[libvirt] [PATCH 1/5] Don't set netdev offline in container cleanup

[Eric Blake]

On 10/02/2013 05:31 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
> 
> During container cleanup there is a race where the kernel may
> have destroyed the veth device before we try to set it offline.
> This causes log error messages. Given that we're about to
> delete the device entirely, setting it offline is pointless.
> 
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>  src/lxc/lxc_process.c | 1 -
>  1 file changed, 1 deletion(-)

ACK.

> 
> diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c
> index f92c613..a78784e 100644
> --- a/src/lxc/lxc_process.c
> +++ b/src/lxc/lxc_process.c
> @@ -193,7 +193,6 @@ static void virLXCProcessCleanup(virLXCDriverPtr driver,
>          virDomainNetDefPtr iface = vm->def->nets[i];
>          vport = virDomainNetGetActualVirtPortProfile(iface);
>          if (iface->ifname) {
> -            ignore_value(virNetDevSetOnline(iface->ifname, false));
>              if (vport &&
>                  vport->virtPortType == VIR_NETDEV_VPORT_PROFILE_OPENVSWITCH)
>                  ignore_value(virNetDevOpenvswitchRemovePort(
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131002/ff78f93b/attachment-0001.sig>