[libvirt] [PATCH 1/2]virsh: enable attatch-disk command option '--mode' accept two parameters

Daniel P. Berrange berrange at redhat.com
Tue Oct 15 09:42:18 UTC 2013


On Tue, Oct 15, 2013 at 11:54:27AM +0800, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> 
> Current disk could accept both 'readonly' and 'shareable'
> at the same time.
> But '--mode' could only accept one parameter.
> 
> This patch enables '--mode' accept parameters like examples below:
> 
> virsh # attach-disk domain /home/1.img sdd --mode shareable,readonly

That does not make sense - these options are mutually
exclusive. Anything 'readonly' is implicitly 'shareable'
without 'shareable' being required.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list