[libvirt] libvirt python is not correctly passing file descriptors to underlying virDomainCreateWithFiles

[Marian Neagul]

Dear All,

	While working on a component handling container management I stumbled on a bug in the libvirt python bindings: basically the python bindings fail in properly translating the python file descriptor list to a native C array.
	The primary symptom was that inside the container the file descriptors are created but mapped to '/dev/null' instead of the original file descriptors

	This problem was discovered in libvirt 1.1.2 but the problem exists also in the current git head.

	I'm attaching a simple patch fixing the bug, and re-establishing the expected behaviour.
	I've also opened a bugzilla issue at https://bugzilla.redhat.com/show_bug.cgi?id=1021434

	I hope this fix is acceptable and that it can be incorporated in the code base. :)

Marian  


~~~~~~~~~~~~~~~
Marian Neagul
Universitatea de Vest din Timisoara
Facultatea de Matematică și Informatică
Centrul de Cercetare in Informatica

marian at info.uvt.ro
marian at hpc.uvt.ro



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131021/d5656349/attachment-0002.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt-python-fix-lxc-fd-passing.patch
Type: application/octet-stream
Size: 672 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131021/d5656349/attachment-0001.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131021/d5656349/attachment-0003.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131021/d5656349/attachment-0001.sig>