[libvirt] [PATCH] qemu: fix well-formed migration URI formatting

Eric Blake eblake at redhat.com
Tue Oct 29 14:33:45 UTC 2013


On 10/22/2013 10:15 PM, Michael Chapman wrote:
> When adding an automatically allocated port to a well-formed migration
> URI, keep it well-formed:
> 
>   tcp://1.2.3.4/  ->  tcp://1.2.3.4/:12345   # wrong
>   tcp://1.2.3.4/  ->  tcp://1.2.3.4:12345/   # fixed
>   tcp://1.2.3.4   ->  tcp://1.2.3.4:12345    # still works
>   tcp:1.2.3.4     ->  tcp:1.2.3.4:12345      # still works (old syntax)
> 
> Signed-off-by: Michael Chapman <mike at very.puzzling.org>
> ---
>  src/qemu/qemu_migration.c | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)
> 

Apologies for the slow review time.

ACK and pushed.  A testsuite addition would also be nice, to prove we
don't regress...

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131029/f72e94d0/attachment-0001.sig>


More information about the libvir-list mailing list