[libvirt] [PATCH] maint: avoid further typedef accidents

Eric Blake eblake at redhat.com
Wed Oct 30 23:03:56 UTC 2013


On 10/30/2013 02:24 AM, Ján Tomko wrote:
> On 10/29/2013 09:04 PM, Eric Blake wrote:
>> To make it easier to forbid future attempts at a confusing typedef
>> name ending in Ptr that isn't actually a pointer, insist that we
>> follow our preferred style of 'typedef foo *fooPtr'.
>>
>> * cfg.mk (sc_forbid_const_pointer_typedef): Enforce consistent
>> style, to prevent issue fixed in previous storage patch.
>> * src/conf/capabilities.h (virCapsPtr): Fix offender.
>> * src/security/security_stack.c (virSecurityStackItemPtr):
>> Likewise.
>> * tests/qemucapabilitiestest.c (testQemuDataPtr): Likewise.
>>
>> Signed-off-by: Eric Blake <eblake at redhat.com>
>> ---
>>  cfg.mk                        | 4 ++++
>>  src/conf/capabilities.h       | 4 ++--
>>  src/security/security_stack.c | 2 +-
>>  tests/qemucapabilitiestest.c  | 2 +-
>>  4 files changed, 8 insertions(+), 4 deletions(-)
>>
> 
> ACK

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131030/5f556a9d/attachment-0001.sig>


More information about the libvir-list mailing list