[libvirt] qemu: Unlock the NWFilter update lock by leaving via the cleanup label

Stefan Berger stefanb at linux.vnet.ibm.com
Wed Apr 16 21:54:36 UTC 2014


Fix a locking problem by leaving the function via the cleanup label.

Signed-off-by: Stefan Berger <stefanb at linux.vnet.ibm.com>

---
  src/qemu/qemu_driver.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Index: libvirt-acl/src/qemu/qemu_driver.c
===================================================================
--- libvirt-acl.orig/src/qemu/qemu_driver.c
+++ libvirt-acl/src/qemu/qemu_driver.c
@@ -6140,7 +6140,7 @@ qemuDomainCreateWithFlags(virDomainPtr d
      virNWFilterReadLockFilterUpdates();

      if (!(vm = qemuDomObjFromDomain(dom)))
-        return -1;
+        goto cleanup;

      if (virDomainCreateWithFlagsEnsureACL(dom->conn, vm->def) < 0)
          goto cleanup;




More information about the libvir-list mailing list