[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib] [PATCH v2 1/4] GVirDomainSnapshot: Add _get_is_current



On Thu, Aug 7, 2014 at 12:05 PM, Christophe Fergeau <cfergeau redhat com> wrote:
> Series looks good to me apart from that naming comment in 4/4.
> If someone does not like the use of gboolean *is_current as a return
> value in
> gboolean gvir_domain_snapshot_get_is_current(GVirDomainSnapshot *snapshot,
>                                              guint flags,
>                                              gboolean *is_current,
>                                              GError **error) {
>
> now would be a good time to complain ;)

None from me at least but I only just realized now that its not really
a simple getter (with out param and error) so I take back my
suggestion to have "_get_" in the name. I don't mind it being there
though so I'll let Christophe decide. :)

-- 
Regards,

Zeeshan Ali (Khattak)
________________________________________
Befriend GNOME: http://www.gnome.org/friends/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]