[libvirt] [PATCH 1/2] Refactor virMutexInit virRWLockInit and virCondInit

Eric Blake eblake at redhat.com
Fri Jul 18 13:30:38 UTC 2014

On 07/17/2014 10:49 PM, Jincheng Miao wrote:
> Implement InitInternal functions for Mutex, RWLock and Cond, these functions
> contain error report using virReportSystemErrorFull, it is controlled by
> an argument 'quite'.
> The related macros are Init and InitQuite, they call InitInternal function
> by passing 'false' or 'true' to quite argument.

After your patch 2, do we really have any callers that use the quiet
version? This seems like the sort of patch where ALL callers should be
noisy (especially since the failure is so rare, but also means we are
quite hosed if it happens).  What are the callers that you intend to be
quiet, and what is the justification for them being quiet?

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140718/5cfff888/attachment-0001.sig>

More information about the libvir-list mailing list