[libvirt] [PATCH 1/2] Refactor virMutexInit virRWLockInit and virCondInit

Jincheng Miao jmiao at redhat.com
Sun Jul 20 04:36:42 UTC 2014

----- Original Message -----
> After your patch 2, do we really have any callers that use the quiet
> version? This seems like the sort of patch where ALL callers should be
> noisy (especially since the failure is so rare, but also means we are
> quite hosed if it happens).  What are the callers that you intend to be
> quiet, and what is the justification for them being quiet?

Eric, yes, if mutex initialization fails, it is very fatal to libvirt,
and I can't give an example for quiet version used. Maybe the 'quiet'
is not useful, and I will depart quiet from my next patch.

Thanks for your review.

> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org

More information about the libvir-list mailing list