[libvirt] [PATCH v2 2/3] nodedev: move pci express types to virpci.h

Eric Blake eblake at redhat.com
Mon Jul 28 20:11:39 UTC 2014

On 07/24/2014 04:03 AM, Martin Kletzander wrote:
> On Wed, Jul 23, 2014 at 09:06:07PM -0600, Eric Blake wrote:
>> Finding virPCIE* code is more intuitive if located in virpci.h
>> instead of node_device_conf.h.

>> +struct _virPCIEDeviceInfo {
>> +    /* Not all PCI Express devices has link. For example this 'Root
>> Complex
> I know it's pre-existing, but reading "devices has link" makes the
> back of my head itch, shouldn't it be 'have'?  Could you change it if
> I am right?

You are right; 'all ... devices' is plural, so it should pair with
'have'.  Fixed, and series pushed.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140728/9d8d6615/attachment-0001.sig>

More information about the libvir-list mailing list