[libvirt] [PATCH 1/2] Refactor virMutexInit virRWLockInit and virCondInit

[Martin Kletzander]

On Fri, Jul 18, 2014 at 07:30:38AM -0600, Eric Blake wrote:
>On 07/17/2014 10:49 PM, Jincheng Miao wrote:
>> Implement InitInternal functions for Mutex, RWLock and Cond, these functions
>> contain error report using virReportSystemErrorFull, it is controlled by
>> an argument 'quite'.
>> The related macros are Init and InitQuite, they call InitInternal function
>> by passing 'false' or 'true' to quite argument.
>
>After your patch 2, do we really have any callers that use the quiet
>version? This seems like the sort of patch where ALL callers should be
>noisy (especially since the failure is so rare, but also means we are
>quite hosed if it happens).  What are the callers that you intend to be
>quiet, and what is the justification for them being quiet?
>

I think there are few callers that error out with VIR_ERROR(), but
most of them just return -1 with no apparent reason.  I'm not sure
about few class initializations (virOnceInit) and driver
initializations.  Do we want to be loud on that front as well?

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140723/3214a1c6/attachment-0001.sig>