[libvirt] [PATCH] build: work around FreeBSD stdlib.h bug

[Daniel P. Berrange]

On Tue, Mar 04, 2014 at 06:28:17AM -0700, Eric Blake wrote:
> POSIX requires that <stdlib.h> expose WIFEXITED and friends,
> but FreeBSD and others fail to comply.  We can work around it
> manually by including <sys/wait.h>, or we can work around it
> automatically by using gnulib's system-posix module.
> 
> * bootstrap.conf (gnulib_modules): Add system-posix.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
> 
> I'll wait for a review on this one - we don't use system(),
> and it feels a little bit odd to list the system() module
> merely for its side effect of a fixed <stdlib.h>.  The alternative
> is to continue using <sys/wait.h> everywhere that we use
> WIFEXITED and friends.

Perhaps we should have a helper in util/virprocess.{c,h} for
this, so no code outside that file ever need use WIFEXITED ?

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|