[libvirt] [PATCH] bhyve: allow to destroy only active domains

[Daniel P. Berrange]

On Sat, Mar 15, 2014 at 07:49:14PM +0400, Roman Bogorodskiy wrote:
> Add a check that domain is active before attempting to destroy it.
> ---
>  src/bhyve/bhyve_driver.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
> index 9dbb299..60d49de 100644
> --- a/src/bhyve/bhyve_driver.c
> +++ b/src/bhyve/bhyve_driver.c
> @@ -567,6 +567,12 @@ bhyveDomainDestroy(virDomainPtr dom)
>      if (virDomainDestroyEnsureACL(dom->conn, vm->def) < 0)
>          goto cleanup;
>  
> +    if (!virDomainObjIsActive(vm)) {
> +        virReportError(VIR_ERR_OPERATION_INVALID,
> +                       "%s", _("Domain is not running"));
> +        goto cleanup;
> +    }
> +
>      ret = virBhyveProcessStop(privconn, vm, VIR_DOMAIN_SHUTOFF_DESTROYED);

ACK

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|