[libvirt] [patch v3 2/2] add inotify handler to qemu driver

Jiri Denemark jdenemar at redhat.com
Thu May 15 09:25:16 UTC 2014


On Wed, May 07, 2014 at 18:11:50 +0800, Chen Fan wrote:
> we don't expect to reload 'migrate_uri' with restarting libvirtd everytime while
> updating the URI, so adding inotify handler to reload 'migrate_uri' configuration
> without restarting libvirtd, it will be also helpful for virt-manager to get
> 'migrate_uri'.

NACK, if we ever want configuration to be automatically reloaded when
configuration file changes (which I seriously doubt, SIGHUP is the
standard way of reloading configuration files), we certainly would not
want to do it this hacky way and only for one specific option. Not to
mention that the content of virQEMUDriverConfig must not change, a
completely new structure has to be created with the changed values.

Anyway, it's good you removed it from v4.

Jirka




More information about the libvir-list mailing list