[libvirt] [RFC] libvirt-admin: Mark symbols as local
Guido Günther
agx at sigxcpu.org
Wed Aug 12 09:10:43 UTC 2015
On Wed, Aug 12, 2015 at 10:37:30AM +0200, Martin Kletzander wrote:
> On Tue, Aug 11, 2015 at 09:24:59PM +0200, Guido Günther wrote:
> >Otherwise we're leaking some 30+ symbols like
> >
> > virAdmConnectClass
> > virAdmConnectNew
>
> ==========
>
> > virConnectClass
> > virConnectCloseCallbackDataClass
> > virDomainClass
>
> These three are not related to libvirt-admin, they are leaked from
> datatypes, I guess. We need libvirt_admin_private.syms that will act
> for admin the same way as libvirt_private.syms acts fr the libvirt
> library.
These will simply be catched by the:
local:
*;
so we don't need a _private.syms for these...
>
> > ...
> >
> >I marked the one symbol needed by the deamon as
> >LIBVIRT_ADMIN_PRIVATE_<VERSION> for now.
> >---
> >
> >There's likely a better solution for xdr_admin_connect_open_args.
>
> What I don't understand is how come there's a problem with xdr
> structures. Thanks for noticing, though, I'll look into it.
...and if we get rid of xdr_admin_connect_open_args we don't need to
intruce any LIBVIRT_ADMIN_PRIVATE_* at all.
Cheers,
-- Guido
More information about the libvir-list
mailing list