[libvirt] [PATCH v3 0/2] Sync macvtap device modes when guest rxfilter changes

[Michal Privoznik]

On 22.01.2015 20:47, akrowiak at linux.vnet.ibm.com wrote:
> From: Tony Krowiak <akrowiak at linux.vnet.ibm.com>
> 
> This patch set provides the code to synchonize some macvtap device 
> modes when the values are changed on the guest's network device.  The 
> following modes will by synchronized:
> * PROMISC
> * MULTICAST
> * ALLMULTI
> 
> I noticed something while testing this patch set that did not occur prior 
> to installing more recent kernel and Qemu distributions.  It seems that 
> the VLAN table always has an entry for VLAN ID 0 when the rxfilter is 
> queried during processing of the NIC_RX_FILTER_CHANGED event.  That means
> that the PROMISC flag for macvtap0 will be set.  I don't know if this 
> will cause problems, but I thought I'd make note of it in case anybody
> wants to comment on that.
> 
> v2 changes:
> * virnetdev.c
>         * Changed names of virNetDevIs... functions to virNetDevGet...
>         * Consolidated code for getting/setting of device option flags
> * qemu_driver.c
>         * Replaced "default" case in syncNicRxFilterMultiMode function with 
>           VIR_NETDEV_RX_FILTER_MODE_NONE
> 
> v3 changes:
> * virnetdev.c
>         * Fixed a syntax-check error in virNetDevGetRxFilter function
> 
> Tony Krowiak (2):
>   util: Functions for getting/setting device options
>   qemu: change macvtap device options in response to
>     NIC_RX_FILTER_CHANGED
> 

I've fixed the small nits I've found, and pushed.

Michal