[libvirt] [PATCH] conf: more useful error message when pci function is out of range

Laine Stump laine at laine.org
Wed Jul 22 16:04:41 UTC 2015


If a pci address had a function number out of range, the error message
would be:

  Insufficient specification for PCI address

This was due to an unnecessary call to virDevicePCIAddressIsValid()
during parse of the pci address - we will anyway check for validity of
the PCI address later on.

With that extra check removed, the error message is the much more useful:

  Invalid PCI address 0000:02:06.8. function must be <= 7

This resolves:

  https://bugzilla.redhat.com/show_bug.cgi?id=1004596
---
 src/conf/device_conf.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c
index e7b7957..09a7019 100644
--- a/src/conf/device_conf.c
+++ b/src/conf/device_conf.c
@@ -1,7 +1,7 @@
 /*
  * device_conf.c: device XML handling
  *
- * Copyright (C) 2006-2012 Red Hat, Inc.
+ * Copyright (C) 2006-2015 Red Hat, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
@@ -115,11 +115,6 @@ virDevicePCIAddressParseXML(xmlNodePtr node,
         goto cleanup;
 
     }
-    if (!virDevicePCIAddressIsValid(addr)) {
-        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-                       _("Insufficient specification for PCI address"));
-        goto cleanup;
-    }
 
     ret = 0;
 
-- 
2.1.0




More information about the libvir-list mailing list